Adding a prop that can contain a callback function that will receive isVisible#39
Adding a prop that can contain a callback function that will receive isVisible#39blaineo wants to merge 2 commits intofkhadra:masterfrom
Conversation
…es the isVisible value )
|
@fkhadra I'd love to have this functionality in your component. Is there any reason it can not be merged and released? If you don't plan on doing so, please let me know so that I can move forward with a fork. Many thanks. |
|
Hello @blaineo, Sorry for the late reply. Since the end of december I'm preparing my move so I'm quite busy. It will be done at the end of the month. I'll try to review your PR asap even this weekend if I can. |
|
It might be useful for the callback to receive some more data and be able to extrapolate which side[s] of the screen the component is off-screen of. |
|
@liao-frank I think in the sprit of reducing complexity and keeping the component abstract, that kind of functionality would be handled in the referenced callback. |
|
My thought process was that, in order to implement the functionality that I suggested, someone would have to re-implement the But perhaps this suggestion is a larger design choice that needs to be approved. I should probably first suggest to have the rect passed to the child render function. |
This will be helpful for setting state of parent components.